NickPiscitelli/Glider.js

Aria roles for glider-dots are not contained by their required parent element

Opened this issue · 2 comments

IshfaqAhmedProg commented

image

Steps to Reproduce:

  1. Create a project and configure it to use glider-js
  2. Enable dots in glider-js config.
  3. Run Lighthouse Analysis on the app

Expected Fix

  1. The .glider-dots parent container should have aria role "tablist" if the aria role for each .glider-dot is "tab".

As stated in https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Roles/tab_role

Elements with the role tab must either be a child of an element with the tablist role, or have their id as part of the aria-owns property of a tablist

Possible Fix _.dots.setAttribute('role','tablist') to the function below in glider.js file

image

jennypns commented

I think this has been fixed, but nobody commented on your issue. :( In glider.js line 222, I see the attribute set just as you suggested.

glider-js-line-222-role-tablist

IshfaqAhmedProg commented

yes, it's been fixed! Thanks @kevinfarrugia for fixing it!

  • 👍1