NicolasPetton/zerodark-theme

differently looking alt modeline

Closed this issue · 13 comments

ninrod commented

hi @NicolasPetton, and thanks for the awesome theme.

I've just installed zerodark with

(use-package zerodark-theme
      :init
      (load-theme 'zerodark t)
      (zerodark-setup-modeline-format-alt)
      :defer t
      :ensure t)

And it is working correctly, except the modeline is looking cheap while the screenshots that you've posted look sick and awesome. Note that I've setup all the dependencies correctly, all-the-icons, everything. Here's a screenshot:

screen shot 2016-11-23 at 09 51 06

I want that the modeline looks like exactly like this:
screen shot 2016-11-23 at 09 52 59

Is that possible? Thanks in advance

ninrod commented

I've tried to tweak the height through customization of the powerline-height variable, but the modeline does not care about that variable. here's a screenshot with evaluation of (zerodark-setup-modeline-format):

screen shot 2016-11-23 at 09 59 09

the height seems to be the main problem here.

NicolasPetton commented

@ninrod I don't think the modeline looks cheap, but that's a matter of taste I guess.
I removed the padding on the modeline, but you can easily add it if you like it. The old modeline face looked like this:

   `(mode-line ((,class (:background ,background-blue :height 0.9 :foreground ,blue
                                     :box ,(list :line-width 4 :color background-blue)))))
   `(mode-line-inactive ((,class (:background ,background-darker :height 0.9 :foreground ,default
                                              :box ,(list :line-width 4 :color background-darker)))))
   `(header-line ((,class (:inherit mode-line-inactive))))
NicolasPetton commented

yes, that's what I mean.

What makes the current modeline look "cheap" to you? The lack of padding and the white border around it?

ninrod commented

@NicolasPetton sorry about using the "cheap" (english not my main language) word! By cheap I meant "very different from the portrayed modeline on the repo".

I think that the "old modeline", which is shown in the repo, just blends so well with your overall color selection. Plus it feels more "emacsy". Don't you think? It's simple and elegant. The new one feels more compact and cluttered.

I can say that, I find this modeline is the most awesome I've seen in github.

I'd love if you implemented a variable for getting that lovely old modeline back? maybe a zerodark-old-modeline command?

would be awesome!

manuel-uberti commented

For what is worth, I like the old modeline very much too. :)

NicolasPetton commented

Manuel Uberti notifications@github.com writes:

For what is worth, I like the old modeline very much too. :)

I experimented quite a bit with modelines in zerodark lately, so which
one? :)

manuel-uberti commented

@NicolasPetton yes, this one: https://cloud.githubusercontent.com/assets/8352747/20560880/b1593e60-b162-11e6-880c-ba4592274322.png

To be honest, I like the dark variant with the icons too. It's up to you. :)

  • 👍1
NicolasPetton commented

Filipe Silva notifications@github.com writes:

@NicolasPetton @manuel-uberti yes! the dark one also looks awesome:

https://raw.githubusercontent.com/NicolasPetton/zerodark-theme/master/screenshot-mode-line-format-alt1.png

Ok, you conviced me, I'll work more on these, stay tuned!

  • 👍2
  • 🎉1
  • ❤️1
NicolasPetton commented

I just released Zerodark 4.0, with the following:

  • it restores the default blue mode-line colors with padding:

screenshot-temp

  • zerodark now only supports one custom mode-line format, as described in the README (the alt mode-line is completely gone):

screenshot-mode-line-format-1
screenshot-mode-line-format-2

/cc @DamienCassou

  • 👍2
  • 🎉1
  • ❤️1
ninrod commented

awesome! gonna test as soon as I can!

edit: I just git cloned and installed manually. the modeline is Just AWESOME! my new official theme.

thank you @NicolasPetton!