NicolasSiver/nodebb-plugin-ns-awards

Some times the management does not show rewards even if the reward is given

Closed this issue · 3 comments

As you can see below,

image

admin has given award to this user and even his awards show on /awards page, but in ACP when i type this user, it says no award given to this user.

i have tested this with multiple users and awards, still same issue.

As you can see in log this user has been awarded before but it does not show in ACP management:
image

To precise. I think it does not work when person gets his 1st award. If you give same person next award everything will be OK.
Let's assume that you give award to person - in /awards it will be shown near the award but in "management" in ACP and in profile it does not (when you put in partial into theme). Next award given is seen everywhere.

Workaround. The -1 value is not handled in a source code. So if you are trying to get award list from database (https://github.com/NicolasSiver/nodebb-plugin-ns-awards/blob/master/plugin/database.js#L228) with limit -1 it will return you all results except the last one. You can make pull request with handling -1 value or just change in plugin settings Max Rewards Per Account field to for example 3.

@mdorda thank you for the pointing into the issue with a limit.