Nike-Inc/cerberus-node-client

List file doesn't paginate

Opened this issue · 1 comments

I noticed when doing the refactor for STS that the list files code didn't support pagination even though the results are potentially paginated.

I didn't fix the bug?, since it was outside the scope of that PR.

Making an issue for community contribution or for us to not forget.

You can see the result for list file here
http://engineering.nike.com/cerberus-node-client/global.html#ListFileResult

if has_next = true then the next_offset should be used for offset in the next call, standard sql pagination.

I think there are 2 options

  1. make list file paginate and return all files
  2. make list file take in limit and offset and let users paginate

I'd vote for 2