NikiforovAll/keycloak-authorization-services-dotnet

Provide extension of `AuthenticationBuilder` to avoid duplicate adding of authentication services

Closed this issue · 2 comments

Mangatome commented

The only methods that allow users to register auth services are the AddKeycloakAuthentication extension methods on IServiceCollection.

These internally call services.AddAuthentication("Bearer"), which is fine when Keycloak is the primary/default auth service.

However, in a scenario where there are several providers and another provider is the default, it gets a bit messier (leading potentially to several calls to AddAuthentication, which is weird).

It's generally not good practice to rewrap calls to such common API as AddAuthentication in third-party libraries. I think it'd be much cleaner to provide an extra set of extensions, but on AuthenticationBuilder that would let one basically set up the library the following way:

services.AddAuthentication()
    .AddKeycloak("MyKeycloakProvider", options => { /* ... */ })
    /* add other providers */
    ;
NikiforovAll commented

That's a great Idea.

I'm thinking of AddKeycloakWebApi similar to AddMicrosoftIdentityWebApi from 'Microsoft.Identity.Web`

ref: https://github.com/Azure-Samples/active-directory-aspnetcore-webapp-openidconnect-v2/blob/master/1-WebApp-OIDC/1-1-MyOrg/Startup.cs#L38