term.asm:28: error: expecting `)'
Shivanshi1729 opened this issue · 5 comments
Shivanshi1729 commented
On building I get this error,
nasm -o build/term.o -felf64 term.asm
term.asm:28: error: expecting `)'
term.asm:29: error: expecting `)'
make: *** [Makefile:21: build/term.o] Error 1
Ubuntu 20.04.3 LTS x86_64
NASM version 2.14.02
NikitaIvanovV commented
I used NASM 2.15 to make the game. Could you try removing the parentheses on these lines? Not sure if it will still be correct syntax but worth a try.
and dword [tty+termios_s.flags], (~ICANON)
and dword [tty+termios_s.flags], (~ECHO)
Deleted user commented
nasm -o build/term.o -felf64 term.asm
term.asm:28: error: comma, colon, decorator or end of line expected after operand
term.asm:29: error: comma, colon, decorator or end of line expected after operand
make: *** [Makefile:21: build/term.o] Error 1
It gives this error on removing parentheses.
NikitaIvanovV commented
Could you guys try to replace 3rd and 4th lines with this?
%define ICANON (1<<1)
%define ECHO (1<<3)
If it doesn't work, try removing parentheses.
Deleted user commented
Thanks, that solves the issue.
NikitaIvanovV commented
Awesome! I've added the fix to the master branch. Thank you for reporting the problem guys!