No need to wait after Wire.requestFrom().
Koepel opened this issue · 2 comments
Koepel commented
In some files, there is a while(Wire.available() after the Wire.requestFrom(). All of those can be removed.
Explanation: Common-mistakes#1
I noticed them in the files:
- NOKO/src/V10/tools/NOKO_Diagnostics/NOKO_Diagnostics.ino
- NOKO/src/V20/tools/NOKO_Diagnostics/NOKO_Diagnostics.ino
- NOKO/src/V10/English/NOKO/Si4703.cpp
- NOKO/src/V10/Deutsch/NOKO/Si4703.cpp
- NOKO/src/V20/English/NOKO/Si4703.cpp
- NOKO/src/V20/Deutsch/NOKO/Si4703.cpp
NikolaiRadke commented
Thanks for the advice.
I removed the obsolete code and checked the other common mistakes mentioned in your link!
NikolaiRadke commented
No, i am not only checking the common mistakes, i am reading your complete wiki.
Very handy!