Ignore hidden dirs
drvinceknight opened this issue · 6 comments
Hidden directories (.git/, .venv/) might contain .ipynb files, perhaps we should omit them by default?
I am inclined to agree. Maybe as a part of #11 there should be an --all flag to not ignore them?
Yeah good idea I think #11 should aim to mimic black in the command line tool as well. I think there are flags there to say what is omitted and included.
What's best in the mean time:
- Leave as is? (It's "clear" if you know what hidden dirs you have.)
- Change to omit hidden dirs (It's "clearer" if you're not too sure what's happening in your hidden dirs - see #23).
I agree that the command line tool should mimic black. With that in mind, is doing the work to implement something that will eventually get chucked a bit pointless? For lack of a better word.
There are always going to be weird edge cases but the bottom line is that this tool is made to be Black for Jupyter notebooks, and Black is Black. So, any and all work should be towards achieving that rather than deviating temporarily to go over it again.
So: "Leave as is" for now?
Yeah, I think so.
Sounds good to me 👍