Check if the division by zero in int/include/nil/blueprint/components/systems/snark/plonk/flexible/colinear_checks.hpp is ok.
martun opened this issue · 0 comments
martun commented
In int/include/nil/blueprint/components/systems/snark/plonk/flexible/colinear_checks.hpp we are dividing by value of "s", which is sometimes zero. I changed it to
assignment.witness(component.W(block*5 + 8), start_row_index + row) = ((alpha + s ) * y0 - (alpha - s) * y1 ) * (s == 0u ? 0u : (2 * s).inversed()); // new fake y
But I'm not sure if this was a bug, or it's ok that S is sometimes zero. Please check.