NixOS/ofborg

Eval tests should be executed with the lowest supported Nix version (2.3)

sternenseemann opened this issue · 4 comments

sternenseemann commented

I ran into the first instance of path interpolation syntax slipping into nixpkgs today: NixOS/nixpkgs#188466. Our lib/minver.nix prescribes that we support everything from 2.3 upwards.

Without CI to catch it, it is quite understandable that contributors accidentally introduce such changes (who remembers the changelog precisely?). Running the eval checks on the oldest supported Nix version should be enough, as any accepted Nix expressions under 2.3 should be forwards compatible.

Deleted user commented

I made this mistake too: NixOS/nixpkgs#210207

OfBorg really needs to check this.

SuperSandro2000 commented

This would also remove all performance optimizations done since the minimum supported versions.

  • 👍1
infinisil commented

This is now implemented in Nixpkgs directly: NixOS/nixpkgs@013acf2