Njanderson/resmon

setting has invalid type, expected string[]

Opened this issue · 1 comments

I am a Mac user.

In VSCode settings ui, Resmon>Disk: Drives setting reports Setting has an invalid type, expected "String[]". Fix in JSON.

When you try to edit "resmon.disk.drives" in user settings json, these values do not work:

  • null
  • "/dev/disk1s5"
  • "/Volumes/mbp"
  • ["/dev/disk1s5"]
  • ["/Volumes/mbp"]
  • "['/Volumes/mbp']"

README notes "C:" for Windows and '/dev/sda1' for Linux. No examples for Mac. Single quotes are not accepted in settings JSON at all.

Although I don't want to see disk space in the status bar, what is the correct value to enter for resmon.disk.drives ?

This has been fixed in 63cc9d7, but it seem that did not make it into the store version. The previous version had an incorrect type in package.json:

resmon/package.json

Lines 66 to 69 in e3cf473

"resmon.disk.drives": {
"type": "string[]",
"default": []
},

I tried modifying package.json along the lines of 63cc9d7, which fixed the JSON error but did not enable the functionality.

By the way, I think the expected notation is

"resmon.disk.drives": [
        "/home/bers",
        "/data/bers",
    ],