Node-DC/Node-DC-EIS

client does not seed RNG so loads are not repeatable

Opened this issue · 1 comments

Thoughts on a patch like this?

diff --git a/Node-DC-EIS-client/runspec.py b/Node-DC-EIS-client/runspec.py
index 72c228a..12588c1 100755
--- a/Node-DC-EIS-client/runspec.py
+++ b/Node-DC-EIS-client/runspec.py
@@ -50,6 +50,14 @@ import traceback
 import urllib
 import util
 
+# Seed RNG for consistent runs?
+if os.environ.get('NODE_DC_EIS_RNG_SEED'):
+  rng_seed = int(os.environ.get('NODE_DC_EIS_RNG_SEED'))
+else:
+  rng_seed = None
+print "Using seed {}".format(rng_seed)
+seed(rng_seed)
+
 """
 #  All globals
 """

Related: interested in a PR to expose CPU_COUNT as a cluster env var for easy scripting?

diff --git a/Node-DC-EIS-cluster/server-cluster.js b/Node-DC-EIS-cluster/server-cluster.js
index e0ae7cc..6f59487 100644
--- a/Node-DC-EIS-cluster/server-cluster.js
+++ b/Node-DC-EIS-cluster/server-cluster.js
@@ -20,7 +20,12 @@ var appConfig = require('./config/configuration');
 var app_host = appConfig.app_host;
 var port = appConfig.app_port;
 const os = require('os');
+
+// Get cpuCount, override with env var.
 var cpuCount = Number(appConfig.cpu_count);
+if (process.env.CPU_COUNT) {
+       cpuCount = Number(process.env.CPU_COUNT);
+}
 
 function printHostInfo() {
   console.log('********************************');