NodeBB/nodebb-plugin-markdown

Rude checkbox selector.

yariplus opened this issue · 6 comments

The plugin indiscriminately selects all checkboxes in a post, and stops other plugins from using checkboxes because it overrides the click event. Need to add a class to designate the checkbox as added by the Markdown plugin.

@pauljherring @BenLubar Too little too late for TDWTF, but here it is 😄

I don't believe I've seen checkboxes used on ours...

....

... because they're not enabled or something?

https://what.thedailywtf.com/topic/25119/checkboxes

Raw:
image

Live:
image

Anyway, just an observation, not necessarily a bug report.

I believe they're sanitized out, but some plugin you guys were using (details plugin) fell back to checkboxes as a shim in IE. This ought to fix that, even though a workaround was already put in place.

Are we using some sort of GitHub flavored markdown in NodeBB?

  • Because
  • that's
  • what
  • this
  • is.

Not specifically, no. We just enabled the checkbox plugin in Markdown is all 👍