Accounts: Audit MUI theme
esteban-gs opened this issue · 6 comments
It seems like our primary color may have been changed in our previous work and in some places it makes sense to match mocks. In others it doesn't. Note that our color palette is set globally.
Let's make a few reusable buttons that follow our standard color palette and can be reused across the app or update the existing ones based on the mocks, with either primary or secondary colors.
Use the buttons in the right view based on the mocks.
Refer to: https://github.com/Nonprofit-Exchange-Hub/web-app/blame/main/client/src/theme/palette.ts#L7
Acceptance criteria:
- Preferably, we use our reusable buttons where it appropriate.
- Color Pallatte captures the colors in our mocks.
See the regression on https://npc-fm7ocfzuva-uw.a.run.app/signup-citizen. Note: the screenshot below is only to show where our button colors have regressed, and it may look different at the time a dev picks this up.
@esteban-gs would this page being redone negate this work? if that's the case should we just start with the redesign based on the new mocks instead?
cc: @jalapenojames
@esteban-gs would this page being redone negate this work? if that's the case should we just start with the redesign based on the new mocks instead? cc: @jalapenojames
The screenshot is probably old, and I should have linked directly to the new figma. This work would still be necessary because the theme and color palette is set globaly.
hi @jalapenojames. Hope all is well. I just wanted to check-in and see if you had any questions regarding this ticket.
That'd be great if you could continue helping with this, and understood re: your Friday deadline. Feel free to open a PR whenever you're ready. Thanks, @jalapenojames!
hi @jalapenojames, hope all is well. Any updates on this ticket? Thanks in advance!