Noovolari/leapp

Add Account Number to Session List

Opened this issue · 1 comments

cdelcastillo commented

Is your feature request related to a problem? Please describe.
When I receive messages from AWS, they often reference the Account by the Account ID.
It would be great if that information is available in the Session list.

Describe the solution you'd like
I envision the Session list having an Account ID column or a subscript under the session name.

Describe alternatives you've considered
I keep my corporate AWS Single SignOn available which shows me this information.

Additional context
Here's a screenshot of what I am envisioning:
accountID_example
Either a column with the Account ID or as in example #3 under the Session name.

siipimutteri commented

I missed this feature and started working on it.
https://github.com/siipimutteri/siipimutteri-leapp/tree/536_accountid_to_sessionlist

I added column for it just like in your screenshot, but the text is currently formatted like named profile (not orange)

Works:

  • Account Id for awsSsoRol, awsIamRoleChained and awsIamRoleFederated
  • Sorting
  • Hiding the column
  • Copying the Account Id just like with Named profile

TODO:

  • Decide whether to include it in compact view and how to make it fit
  • CSS optimizations
  • Tests
  • Fetch Account Id for awsIamUser (should be done with sts get-caller-identity when session is added)
  • Parse Account Id for awsIamRoleFederated
  • What to get for Azure, tenantId?