Notification icon missing

[Nickwiz]

Summary:

Notifications uses non-existing icon /var/lib/nordvpn/icon.svg

Detail:

The notify function uses the constant IconPath when sending notifications:

nordvpn-linux/daemon/notify.go

Lines 45 to 55 in 6fd88a4

	func notify(id int64, body string) error {
	var cmd *exec.Cmd
	if internal.IsCommandAvailable("notify-send") {
	cmd = exec.Command(
	"notify-send", "-t", "3000", "-i", IconPath, summary, body,
	)
	} else if internal.IsCommandAvailable("kdialog") {
	cmd = exec.Command(
	"kdialog", "--title", summary, "--passivepopup", body, "--icon", IconPath, "3",
	)
	} else {

where IconPath is defined in constants; typically as /var/lib/nordvpn/icon.svg:

nordvpn-linux/daemon/constants.go

Line 16 in 6fd88a4

IconPath = internal.AppDataPath + "icon.svg"

On install the icon file is copied to /usr/share/icons/hicolor/scalable/apps/nordvpn.svg :

nordvpn-linux/ci/nfpm/template.yaml

Lines 93 to 94 in 6fd88a4

	- src: ${CI_PROJECT_DIR}/assets/icon.svg
	dst: /usr/share/icons/hicolor/scalable/apps/${NAME}.svg

but no link or copy is made to /var/lib/.

One could define IconPath to use the /usr/share/icons path. (Or if any other approach is better).

Quick Fix:

A quick fix for most until remedied.

sudo ln -s /usr/share/icons/hicolor/scalable/apps/nordvpn.svg /var/lib/nordvpn/icon.svg

[EmilijusS]

Thank you. I created #82 and this will be fixed with the next release.