Nordix/metal3-dev-tools

Dev tools integration tests does not stop on error

lentzi90 opened this issue · 0 comments

As seen here the test is not aborted when the upload to artifactory fails. Instead it continues all the way until trying to download that image from artifactory. Of course, this fails and the test is aborted.

We should make sure the test is aborted early if the upload fails.

Here is the error on upload:

++ curl -u****:**** https://artifactory.nordix.org/artifactory/metal3/images/temp/centos_TEMP_IMG_ompx.qcow2 -T /tmp/node_image/centos_TEMP_IMG_ompx.qcow2
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
  1 2567M    0     0    1 39.5M      0   104M  0:00:24 --:--:--  0:00:24  104M
  7 2567M    0     0    7  180M      0   130M  0:00:19  0:00:01  0:00:18  130M
[removed for brevity...]
 94 2567M    0     0   94 2426M      0   132M  0:00:19  0:00:18  0:00:01  136M
 99 2567M    0     0   99 2554M      0   131M  0:00:19  0:00:19 --:--:--  133M
100 2567M  100   157  100 2567M      7   130M  0:00:22  0:00:19  0:00:03  131M
<html>
<head><title>502 Bad Gateway</title></head>
<body>
<center><h1>502 Bad Gateway</h1></center>
<hr><center>nginx/1.20.1</center>
</body>
</html>

And here is the error when trying to download the image later:

+ wget --no-verbose --no-check-certificate https://artifactory.nordix.org/artifactory/metal3/images/temp//centos_TEMP_IMG_ompx.qcow2
https://artifactory.nordix.org/artifactory/metal3/images/temp//centos_TEMP_IMG_ompx.qcow2:
2022-04-20 14:50:14 ERROR 404: Not Found.
make: *** [Makefile:4: install_requirements] Error 8