NuKeeperDotNet/NuKeeper

packages.lock.json incorrectly updated for .NET 5

Bouke opened this issue ยท 7 comments

Bouke commented

๐Ÿ› Bug Report

I have some projects that multi-target .NET Framework 4.8 and .NET 5:

I have enabled (packages.lock.json):

When NuKeeper tries to update dependencies in such a library, the lock file is incorrectly modified to refer to ".NET Framework v5":

diff --git a/Library/packages.lock.json b/Library/packages.lock.json
index 8c0d8df4d..ef34bdeb6 100644
--- a/Library/packages.lock.json
+++ b/Library/packages.lock.json
@@ -59,7 +59,7 @@
         "contentHash": "NfmC8NoxrRtw2PSmqSu+kVTcsJuMhspxWKbVzrtPxw+O8hjpCPzD0IttCUJclDf36qkmScvvd1BgRHYE17zF9g=="
       }
     },
-    ".NETCoreApp,Version=v5.0": {
+    ".NETFramework,Version=v5.0": {
       "IDisposableAnalyzers": {
         "type": "Direct",
         "requested": "[3.4.8, )",

Expected behavior

It shouldn't modify the reference to .NET 5.

Reproduction steps

See above.

Configuration

Version: 0.4.43

Platform if applicable:

  • ๐Ÿ› ๏ธ NuKeeper CLI
  • โœจ GitHub
  • ๐Ÿค– AzureDevops
  • ๐Ÿ Bitbucket
  • ๐ŸŒŽ Gitlab
  • ๐Ÿ“บ Gitea
  • ๐Ÿณ Docker

Hi @Bouke

Would it be possible to include log files with verbosity detailed?

Bouke commented

I'm trying to get those logs, but apparently I was running an old version (0.26.0) due to this bug: NuKeeperDotNet/NuKeeper-AzureDevops-extension#62. Since upgrading my custom package sources aren't being used anymore, running into this bug: #1035 (comment).

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Bouke commented

Iโ€™d like to keep this issue open.

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Bouke commented

Iโ€™d like to keep this issue open.

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.