NuKeeperDotNet/NuKeeper

Could not execute dotnet restore on project names with spaces

kwlin opened this issue · 5 comments

kwlin commented

🐛 Bug Report

We are using NuKeeper on a solution with a project name with spaces. Only the NuKeeper fail while executing dotnet restore with following message:

dotnet restore 07 - Implementation.csproj 
Command dotnet failed with exit code: 1

MSBUILD : error MSB1008: Only one project can be specified.
Switch: Implementation.csproj

For switch syntax, type "MSBuild -help"



Updates failed NuKeeperException : Command dotnet failed with exit code: 1

MSBUILD : error MSB1008: Only one project can be specified.
Switch: Implementation.csproj

For switch syntax, type "MSBuild -help"

Expected behavior

NuKeeper should accept project file names with spaces in it and use quotation while executing dotnet restore.

Reproduction steps

Execute NuKeeper on a solution with spaces in the csproj name.

Configuration

Version: 0.34.0

Platform if applicable:

  • 🛠️ NuKeeper CLI
  • ✨ GitHub
  • 🤖 AzureDevops
  • 🏁 Bitbucket
  • 🌎 Gitlab
  • 📺 Gitea
  • 🐳 Docker
kwlin commented

The issue seems here:

NuKeeper/NuKeeper.Update/Process/DotNetUpdatePackageCommand.cs

Line 44 in 9c14d8b

var restoreCommand = $"restore {projectFileName} {sources}";

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

kwlin commented

Can anyone review & accept my PR #1093 to fix this issue

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

skolima commented

The PR has been merged. Thanks!

  • ❤️2