Nuchaz/BiblioCraft

[1.10.2] Dupe Bug with Fancy WorkBench again..

Opened this issue · 16 comments

I'm on BiblioCraft 2.2.4
Okay here are the steps to how to dupe with Fancy workbench

  1. need two Bags (example two bag of holding from extra utilities) and a book
  2. you put the book in the book slot
  3. now you get one of your bag and full it up with items you wish to dupe with
  4. put the bag with item in the fancy workbench into the crafting slot then Save Recipe to blank book
  5. take out the bag with item out of the crafting slots
  6. load Components from inventory, make sure your loading in the Empty Bag then take out from the crafting slot exit out of the fancy workbench and boom! you duped with 2 bags full with item's

Keep in mind the last dupe with Fancy workbench you'll need the bags to stack in this case you do not need them to stack some how the items in side of the last bag got saved inside of the book and can be loaded into a empty bag

Thanks for the report, I'll see about trying to fix this.

I am having the same problem as well can you fix it asap?

I'll have a fix for this in the next release. I am testing a potential solution right now and then plan to add the fix to 1.10, 1.11, and 1.12 versions.

thanks for fixing this, this was becoming an big issue for me <3 thanks you

This is fixed in the latest release for MC 1.10, 1.11, and 1.12. I just put out the release.

this issue is still Not! fix
version i use BiblioCraft[v2.2.5][MC1.10.2]

I can't reproduce it using the original steps provided and I changed the code so the item that the item that gets moved into the crafting grid comes from your inventory and not the recipe book anymore, which is how the dupe as described here worked. So that dupe is no doubt fixed. Did you discover another dupe? How can I reproduce it?

https://www.youtube.com/watch?v=FMC7WJc4MHE&feature=youtu.be
i made a video for you explain and doing it step by step

thanks for the video. I think I see what is happening. I'll have to put some thought into this and figure out how to fix it.

Also, you should allow to save only valid recipes (with output). I think the output slot could be checked.

For the record, this exploit also exists on 1.7.10.

@Nuchaz best way to fight back on this dupe bug i'll say is to add a item blacklist so players are unable to put bugs into fancy workbench slots

Blacklist are a pain to manage.

do you have any other better idea? since this issue is still here since last year xD

This looks like a classic case of comparing items with only their id and metadata, forgetting to check NBT too.
Practically, I don't know how it's implemented, so it might go deeper in maybe the way the recipe is saved in the book, etc.

I re-watched the video again, and I think I found a relative simple workaround that would help to bring this bug further: when you click load recipe button, refuse to load the recipe if the grid slots are not empty. This prevents overwriting the actual item with the saved one, and since the stored recipe is invalid, placing the item into the grid should not do anything. This would make the in-game usage a slightly worse but would prevent item duplication.