OCA/account-reconcile

Migration to version 13.0

OCA-git-bot opened this issue · 12 comments

OCA-git-bot commented

Todo

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-13.0

Modules to migrate

  • account_banking_reconciliation
  • account_mass_reconcile
  • account_move_base_import
  • account_move_reconcile_helper - By @kittiu #301
  • account_move_so_import
  • account_move_transactionid_import
  • account_partner_reconcile - By @MiquelRForgeFlow - #303
  • account_reconcile_payment_order - By @joao-p-marques - #367
  • account_reconcile_restrict_partner_mismatch - By @ernestotejeda - #298
  • account_reconcile_rule - By @phuctranerp #354
  • account_reconcile_rule_early_payment_discount - By @phuctranerp #356
  • bank_statement_foreign_currency deprecated
  • base_transaction_id deprecated

Missing module? Check https://github.com/OCA/maintainer-tools/wiki/%5BFAQ%5D-Missing-modules-in-migration-issue-list

yvaucher commented

@OCA/accounting-maintainers In l10n-switzerland we will get rid of the dependency on module base_transaction_id. I suggest to not migrate this module to version 13.0. Any objection, was it used elsewhere?

pedrobaeza commented

I think it's used in some reconcile modules by your company.

florian-dacosta commented

@yvaucher https://github.com/OCA/account-reconcile/tree/10.0/account_mass_reconcile_transaction_ref
I think it is still relevant, no?
I actually use this module for a customer (v9)

yvaucher commented

Question is: Will you be using it in version 13.0 or later. In version 9.0 we were lacking a proper field to save a payment reference for reconciliation. But, since version 12.0 I see no reasons to not use the standard reference field.

florian-dacosta commented

I am not sure to know which field exactly you are talking about.
I did not need to install all the reconciliation stuff in version 12 yet, so I am not sure, but I am not aware of a better field for this use.
So AFAIK I would still need it, but I may be wrong.

kittiu commented

Working on account_move_reconcile_helper
#301

  • 👍1
MiquelRForgeFlow commented

bank_statement_foreign_currency is deprecated (or merged into account), because the fields in the view have the optional="hidden"

  • 👍1
MiquelRForgeFlow commented

account_partner_reconcile #303

  • 👍1
phuctranfxvn commented

account_reconcile_rule done here #354

  • 👍1
phuctranfxvn commented

account_reconcile_rule_early_payment_discount migrated here #356

  • 👍1
yvaucher commented

@florian-dacosta as I worked on this again lately for base_transaction_id, you don't need base_transaction_id in version 13.0. The field invoice_payment_ref is there for that. https://github.com/odoo/odoo/blob/13.0/addons/account/models/account_move.py#L202

You can see it is used in the reconcile matching query:
https://github.com/odoo/odoo/blob/13.0/addons/account/models/account_reconcile_model.py#L602

Note: this is different in v12

github-actions commented

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.