[14.0] crm_lead_firstname: False positive match when convert lead

[Doscaal]

Module

crm_lead_firstname

Describe the bug

When you convert a lead in opportunity, there is a look for a potential existing partner relevant.
By default, odoo look on the email and if we don't have a match it look on these criteria partner_name, contact_name, name of the lead.

This is good point but when we use the module crm_lead_firstname, the contact_name field is used to set the firstname.

The consequence is when we convert the lead, odoo is looking for someone with the same firstname and if there is a match it propose to link it and not to create a new partner.

To Reproduce

Affected versions: 14.0

Steps to reproduce the behavior:

1. Create partner Paul Taylor
2. Create a lead with Paul as firstname and Graham as lastname.
3. Convert your lead as an opportunity. The system will propose Paul Taylor as a partner to link to the opportunity instead of creating a new partner

Expected behavior
IF the complete name match, we propose the contact and if not, we propose to create a new one.

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.