account_invoice_import: use native odoo invoice email hook

Question

account_invoice_import: use native odoo invoice email hook

Closed this issue 2 years ago · 7 comments

Odoo provide some hook to plug email invoice decoder
https://github.com/odoo/odoo/blob/540dc692495928fedb297d5b0f2a31ddfd590976/addons/account/models/account_move.py#L3468

I was wondering why not using them to plug mail invoices into this module.

What do you think of this ?

I may carry on some work on this to have native integration.

Answer 1 · 2022-05-03T10:44:33.000Z

I like the idea!
If i remember there was somewhere a discussion about thr refactoring of these edi modules.

Some are quite complex. Some functions can be handled on core now?

Answer 2 · 2022-05-03T16:30:21.000Z

This is the thing that run on new message on invoice :

    def _message_post_after_hook(self, new_message, message_values):
        # OVERRIDE
        # When posting a message, check the attachment to see if it's an invoice and update with the imported data.
        res = super()._message_post_after_hook(new_message, message_values)

        attachments = new_message.attachment_ids
        if len(self) != 1 or not attachments or self.env.context.get('no_new_invoice') or not self.is_invoice(include_receipts=True):
            return res

        odoobot = self.env.ref('base.partner_root')
        if attachments and self.state != 'draft':
            self.message_post(body=_('The invoice is not a draft, it was not updated from the attachment.'),
                              message_type='comment',
                              subtype_xmlid='mail.mt_note',
                              author_id=odoobot.id)
            return res
        if attachments and self.line_ids:
            self.message_post(body=_('The invoice already contains lines, it was not updated from the attachment.'),
                              message_type='comment',
                              subtype_xmlid='mail.mt_note',
                              author_id=odoobot.id)
            return res

        decoders = self.env['account.move']._get_update_invoice_from_attachment_decoders(self)
        for decoder in sorted(decoders, key=lambda d: d[0]):
            # start with message_main_attachment_id, that way if OCR is installed, only that one will be parsed.
            # this is based on the fact that the ocr will be the last decoder.
            for attachment in attachments.sorted(lambda x: x != self.message_main_attachment_id):
                invoice = decoder[1](attachment, self)
                if invoice:
                    return res

        return res

Answer 3 · 2022-05-03T17:48:45.000Z

Have you seen this? #246
I don't have enough knowledge ,but my question is.. Is that code still needed or will the transfer of the invoices be handled by the (new) oca edi module?

Answer 4 · 2022-05-03T21:00:30.000Z

You mean this module : https://github.com/OCA/edi/tree/14.0/edi_oca
Indeed we could create a new backend type email (like storage and webservice)

But then account_invoice_import should provide components for edi_oca to process documents.

I really like this separation between getting/sending docs and processing them.

I'm tagging @simahawk regarding the new backend type.

Answer 5 · 2022-05-04T10:24:32.000Z

There are 2 different things here:

refactoring existing modules to reuse odoo core features
plug such modules into the edi framework

Point one is the main subject of this issue.
Point two is another story. For the long term we might want to re-factor all modules to be based on edi framework (eg: always generate an edi.exchange record) -> to be discussed. Good topic for the OCA days in October ;)

For integrating them, you can reuse all their features (maybe some little changes / fixes required) in a glue module as I did here for sale_order_import https://github.com/OCA/edi/blob/14.0/edi_sale_order_import/components/process.py -> reuse the same wizard.