[16.0] auth_saml: Error decrypt matching_value response to compare output response.name_id.text
randall-vx opened this issue · 1 comments
randall-vx commented
Error trying to decrypt matching_value response to compare output response with response.name_id.text.
It shows AttributeError: 'NoneType' object has no attribute 'text'.
2023-09-17 02:02:54,015 4049 ERROR odoo odoo.addons.auth_saml.controllers.main: SAML2: failure - 'NoneType' object has no attribute 'text'
Traceback (most recent call last):
File "/home/odoo/instance/extra_addons/server-auth/auth_saml/controllers/main.py", line 219, in signin
.auth_saml(
File "/home/odoo/instance/extra_addons/server-auth/auth_saml/models/res_users.py", line 64, in auth_saml
validation = self._auth_saml_validate(provider, saml_response, base_url)
File "/home/odoo/instance/extra_addons/server-auth/auth_saml/models/res_users.py", line 29, in _auth_saml_validate
return provider._validate_auth_response(token, base_url)
File "/home/odoo/instance/extra_addons/server-auth/auth_saml/models/auth_saml_provider.py", line 296, in _validate_auth_response
matching_value = response.name_id.text
AttributeError: 'NoneType' object has no attribute 'text'
Module
auth_saml
Describe the bug
In the class SecurityContext
in __init__
we need an encryption_keypairs
to decrypt matching_value and compare with response.name_id.text
on `auth_saml_provider.py according to the saml2 library
To Reproduce
Affected versions:
16.0 - May affect 15.0
github-actions commented
There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.