`make check` fails with latest code because of missing ocrd-tesserocr-binarize

Question

`make check` fails with latest code because of missing ocrd-tesserocr-binarize

Closed this issue 10 months ago · 5 comments

It looks like none of the ocrd-tesserocr-* executables is installed.

I noticed this first while implementing CI for macOS (see protocol), but could reproduce it with x86_64 as well (see protocol).

Answer 1 · 2024-03-14T18:15:06.000Z

@bertsky, maybe this is not an issue for ocr_all but for ocrd_tesserocr.

Answer 2 · 2024-03-14T21:47:55.000Z

Release v2024-02-01 also fails during make check, but with a different error:

TypeError: 'ocrd_froc.processor' is not a package
make: *** [Makefile:762: /home/runner/work/ocrd_all/ocrd_all/venv/bin/ocrd-froc-recognize-check] Error 1

Answer 3 · 2024-03-14T21:48:42.000Z

@bertsky, maybe this is not an issue for ocr_all but for ocrd_tesserocr.

I have sent a fix in pull request #422.

Answer 4 · 2024-03-14T21:52:58.000Z

@bertsky, I still wonder why the CI continued after make all although that failed to build ocrd_tesserocr. It should have stopped instead of continuing with make check.

Answer 5 · 2024-03-15T06:16:06.000Z

Pull request #422 fixes this issue, see the CI protocol, but now make check fails because of ocrd_froc as with release v2024-02-01. That's a separate issue.