eVital - compliance check
Opened this issue · 3 comments
- /on_action API response time should be less than 5 sec for a particular /action request
/on_search
- Is geocoding of gps coordinates and area code accurate? Reverse geocoding shows different area code
- many invalid keys in /context such as "key", "item_count", "provider_name", "provider_mobile", "provider_address"
- /message/catalog/bpp/providers/0/items/0/@ondc/org/statutory_reqs_packaged_commodities must have required property 'manufacturer_or_packer_address'
- /message/catalog/bpp/providers/0/items/0/@ondc/org/statutory_reqs_packaged_commodities must have required property 'common_or_generic_name_of_commodity'
- /message/catalog/bpp/providers/0/items/0/@ondc/org/statutory_reqs_packaged_commodities must have required property 'net_quantity_or_measure_of_commodity_in_pkg'
- /message/catalog/bpp/providers/0/items/1/@ondc/org/statutory_reqs_packaged_commodities must have required property 'month_year_of_manufacture_packing_import'
- category in serviceability construct should be one of the category ids bpp/providers[0]/items/category_id (ie. "Personal and Baby Care")
- why is hyperlocal serviceability set to 300 km radius?
/on_status
- why are estimated pickup and drop time ranges same?
/on_update
- must have required property 'payment'
/on_action API response time should be less than 5 sec for a particular /action request
looking into it.
/on_search
-
Is geocoding of GPS coordinates and area codes accurate? Reverse geocoding shows different area code
I will check and update it. -
many invalid keys in /context such as "key", "item_count", "provider_name", "provider_mobile", "provider_address"
Those are part of the logs for internal use, they weren't sent in the API call, I will remove them from the logs. -
/message/catalog/bpp/providers/0/items/0/@ondc/org/statutory_reqs_packaged_commodities must have required property 'manufacturer_or_packer_address'
The @ondc/org/statutory_reqs_packaged_commodities is an optional attribute in the OTC pharma category. Hence we have provided some of the fields which are convenient. Same for 4, 5, 6, -
/message/catalog/bpp/providers/0/items/0/@ondc/org/statutory_reqs_packaged_commodities must have required property 'common_or_generic_name_of_commodity'
-
/message/catalog/bpp/providers/0/items/0/@ondc/org/statutory_reqs_packaged_commodities must have required property 'net_quantity_or_measure_of_commodity_in_pkg'
-
/message/catalog/bpp/providers/0/items/1/@ondc/org/statutory_reqs_packaged_commodities must have required property 'month_year_of_manufacture_packing_import'
-
category in the serviceability construct should be one of the category ids bpp/providers[0]/items/category_id (ie. "Personal and Baby Care")
There would be multiple categories, Should I add separate {code:"", value: ""} models for each of them? like below?
"list": [
{
"code": "location",
"value": "YT3/3PEAnmEolCPrStruew=="
},
{
"code": "category",
"value": "Sexual Wellness"
},
{
"code": "category",
"value": "Diabetes Control"
},
{
"code": "category",
"value": "Nutrition and Supplements"
},
{
"code": "type",
"value": "10"
},
{
"code": "val",
"value": "300"
},
{
"code": "unit",
"value": "km"
}
] -
why is hyperlocal serviceability set to a 300 km radius?
It was set to 300 km for testing purposes, In production it is 3-4 km
/on_status
why are the estimated pickup and drop time ranges the same?
because it's a self-delivery, that's why I had put it the same. Please explain what should be the valid values.
/on_update
must have required property 'payment'
As per our discussions, we agreed that it is not mandatory if the on_update is liquidated.
@bluecypher
- statutory_reqs_packaged_commodities are mandatory for pharma categories
- refer to the document for serviceability construct to define multiple serviceabilities
- test scenarios must be realistic and feasible
- pickup time can be set to align with the shipping time
- schema should remain same for /on_update (i.e. payment object is mandatory)
statutory_reqs_packaged_commodities are optional in both of the contracts.
API contract 1.2.0:
API contract extension (Health and Wellness):
Which contract you are referring to?
will update the rest of the changes