Shipsy - compliance check
Closed this issue · 4 comments
abhinavv245 commented
Flow 1
/on_search
- item TAT is given for 2 days, why is /items/time/timestamp provided for the date after 3 days w.r.t context/timestamp
- the approx distance between start and end location is 16km and the shipment is P2H2P, is this intentional? (otherwise realistic pincodes should be provided)
- dimensions are required in /search for P2H2P shipments (LSP should send NACK)
/on_update
- pickup and delivery time range should not be same
/on_track
- /track is applicable for hyperlocal "Immediate delivery" orders for now. (LSP should send NACK in this case)
Flow 2
/on_status
- All states of RTO should be provided
abhinavv245 commented
Flow 2
/on_status
- Provide /on_status responses for all fulfillment states prior to order cancellation
aditya-sharma2-shipsy commented
@abhinavv245 I have added the Pickup Completion log on_status call in the below PR
#454
sandeepshahi commented
/on_track
- invalid NACK error response for /track; 60012 error code should be used
sandeepshahi commented
@BLR-0118, the Shipsy LSP logs v1.1.0 seem fine. Please proceed with your review.