18thDigiTech (BPP) - compliance check
Opened this issue · 4 comments
Common Issues
/on_search
- orders should not be processed from a disabled store
- holidays must be future dated in /locations/time/schedule/holidays
- geocoding of gps and address is inaccurate in /locations
- invalid attribute "Building" in /locations/address
- serviceability construct must be defined for all the "category_id" in /items
- pincode serviceability is not supported by the buyer apps; use hyperlocal or PAN India accordingly
- values can't be "NA" in /@ondc/org/statutory_reqs_packaged_commodities
/on_select
- "@ondc/org/category" and "@ondc/org/TAT" mapping is incorrect; TAT for Immediate Delivery should be <= 60 mins
/on_status (Pending)
- store location details can't change
- estimated pickup and delivery time ranges can't be past dated; should be realistic and feasible
/on_status (Order-picked-up)
- pickup timestamp (/fulfillments/start/time/timestamp) is not captured correctly; can't be the same as in /on_status for "Pending" state
/on_update
- all the interim states for unsolicited /on_update calls must be provided for verification
- timestamp of /on_update (Return_Initiated) can't be earlier than /update call
- order/updated_at must be updated as per the context/timestamp
- estimated reverse QC pickup and delivery timestamps can't be past dated
Flow 2
- select call for non-serviceable /on_select is missing
- order cancellation must be seller initiated as per Flow 2
Flow 4
/on_select (OOS)
- @ondc/org/item_quantity/count must also be 0 in case of OOS
- discount line item in quote/breakup must not be present if 0
Hello,
Please find the below our comments:
/on_search
- orders should not be processed from a disabled store -
Comment: In Magento, there is no functionality to disable the store but the module can be disabled which syncing data with Buyer.
- holidays must be future dated in /locations/time/schedule/holidays
Comment: Holidays are always future dates.
- geocoding of gps and address is inaccurate in /locations
Comment: GPS coordinates changed according to location and will submit the updated PR
- invalid attribute "Building" in /locations/address
Comment: Removed “Building” attribute
- serviceability construct must be defined for all the "category_id" in /items
Comment: Updated and will submit the updated PR
- pincode serviceability is not supported by the buyer apps; use hyperlocal or PAN India accordingly
Comment: Updated to hyperlocal and will submit the updated PR
- values can't be "NA" in /@ondc/org/statutory_reqs_packaged_commodities
Comment: We don’t have information in Magento for this. Let me know if we can remove this field.
/on_select
- "@ondc/org/category" and "@ondc/org/TAT" mapping is incorrect; TAT for Immediate Delivery should be <= 60 mins
Comment: Updated to Next Day Delivery and will submit the updated PR
/on_status (Pending)
- store location details can't change
- estimated pickup and delivery time ranges can't be past dated; should be realistic and feasible
Comment: we have updated this and will raise PR soon.
/on_status (Order-picked-up)
- pickup timestamp (/fulfillments/start/time/timestamp) is not captured correctly; can't be the same as in /on_status for "Pending" state
Comment: Working Already. In the Pending state, no timestamp in start/time.
/on_update
- all the interim states for unsolicited /on_update calls must be provided for verification
- timestamp of /on_update (Return_Initiated) can't be earlier than /update call
Comment: we have updated this and will raise PR soon.
- order/updated_at must be updated as per the context/timestamp
Comment: we have updated this and will raise PR soon.
- estimated reverse QC pickup and delivery timestamps can't be past-dated
Comment: Updated as context.timestamp and will raise PR soon.*
Flow 2
- select call for non-serviceable /on_select is missing
Comment: Please check file with name “on_select_non_servicable.json”.
- order cancellation must be seller initiated as per Flow 2
Comment: Already Working.
Flow 4
/on_select (OOS)
- @ondc/org/item_quantity/count must also be 0 in case of OOS
Comment: Fixed. Count and will raise PR soon.*
- discount line item in quote/breakup must not be present if 0
Comment: Fixed. and will raise PR soon.*
/on_search
- orders should not be processed from disabled store
- geocoding of gps and address is inaccurate in /locations
- statutory reqs are mandatory;values can't be NA
/on_select
- delivery time "@ondc/org/TAT" should be calculated dynamically as per the distance
/on_status
- start locations can't change
- pickup and delivery time ranges are not in sync with time to ship and delivery TAT
- invalid capture of pickup timestamp (/fulfillments/start/time/timestamp) in Order-picked-up state
/on_update (Liquidated)
- quote must be updated in the liquidated state
Flow 2
- select call for non-serviceable /on_select is missing
- order cancellation must be seller initiated as per Flow 2
Flow 4
/on_select (OOS)
- available/maximum count should be 0 incase of OOS
/on_update (Return_Approved)
- invalid start and end location in Reverse QC fulfillment (should be swapped for reverse shipment)
Flow 5
- OOS scenario is missing
/on_search
- orders should not be processed from disabled store
Comment: We have updated fixes in PR.
- geocoding of gps and address is inaccurate in /locations
Comment: GPS coordinates and address are almost accurate
- statutory reqs are mandatory;values can't be NA
Comment: We don’t have information in Magento for this. Let me know if we can remove this field.
/on_select
- delivery time "@ondc/org/TAT" should be calculated dynamically as per the distance
Comment: We are checking logs with other vendors. Please elaborate more about this calculation or how we can find the "@ondc/org/TAT" dynamically.
/on_status
- start locations can't change
Comment: We are not changing the store locations .
- pickup and delivery time ranges are not in sync with time to ship and delivery TAT.
Comment: We have updated fixes in PR.
- invalid capture of pickup timestamp (/fulfillments/start/time/timestamp) in Order-picked-up state
Comment: We have updated fixes in PR.
/on_update (Liquidated)
- quote must be updated in the liquidated state
Comment: We have updated fixes in PR.
Flow 2
- select call for non-serviceable /on_select is missing
Comment: We have included "select_non_serviceable.json" in updated PR.
- order cancellation must be seller initiated as per Flow 2
Comment: We are already done order cancellation as other vendors. Please help us in this issue.
Flow 4
/on_select (OOS)
- available/maximum count should be 0 incase of OOS
Comment: We have updated fixes in PR.
/on_update (Return_Approved)
- invalid start and end location in Reverse QC fulfillment (should be swapped for reverse shipment)
Comment: We have updated fixes in PR.
Flow 5
- OOS scenario is missing
Comment: We have already included oos scenario. Please check /on_select.json.
PR Request:
#721
@bluecypher