OP-Engineering/link-preview-js

replace url module with new URL

rogueturnip opened this issue · 2 comments

Just wanted to suggest that you can remove the old url module with the following
src = new URL(src, rootUrl).toString();

Since this library also works with react native/cordova runtimes and also depending on the Node version, the URL global might not be present... not sure if it is a good idea to drop it.

Yeah, as stated the URL api might not be available on all runtimes. There is no need to change the implementation if it is working properly for now. Closing this.