OSBI/saiku

The code is unreasonable

nagq opened this issue · 0 comments

nagq commented

https://github.com/OSBI/saiku/blob/development/saiku-ui/js/saiku/views/TabSet.js

close_all: function() {
    for (var i = 0, len = this._tabs.length; i < len; i++) {
        var otherTab = this._tabs[i];
        otherTab.remove();
    }
}

should be

close_all: function() {
    for (var len = this._tabs.length, i = len - 1; i >= 0; i--) {
        var otherTab = this._tabs[i];
        otherTab.remove();
    }
}