Relations sometimes incorrectly marked as deleted

[b1tw153]

I'm submitting a bug report

Brief Description

Sometimes OSMCha reports relations as "deleted" when the changeset has only modified the relation.

What is the current behaviour, (attach relevant screenshots) ?

I don't know how common this issue is but I have come across it in several recent changeset reviews. The "+"/"Other Features" tab for features created, deleted, and modified lists some deleted relations. But looking at the relations in OSM and reviewing the OSMChange XML for the changeset, it is clear that the changeset only modified the relations.

This makes it difficult to review changesets because it can lead to the wrong impression that something important was deleted when it was not. And it takes some extra effort to examine each relation to determine what happened.

What is the expected behaviour ?

Relations that are modified but not deleted should be listed under the "Modified Relations" category and not under the "Deleted" category in the "Other Features" tab.

When does this occur ?

I have not been able to identify the specific conditions which cause this to occur but I noticed that the bug was visible while reviewing the following changesets:

https://osmcha.org/changesets/140919220
https://osmcha.org/changesets/140919728
https://osmcha.org/changesets/140919964
https://osmcha.org/changesets/141235234

How do we replicate the issue ?

1. Review one of the changesets listed above
2. Select the "+" tab for "Other Features"
3. Expand the "Deleted" category
4. Select one of the deleted relations
5. Open the relation in OSM and verify that it was not deleted
6. Open the changeset in OSM
7. Open the OSMChange XML data from OSM
8. Review the OSMChange XML data to confirm that the relation in question was modified but not deleted

Please tell us about your environment:

Firefox 119.0 on MacOS Sonoma 14.1

Other Information / context:

Screenshot of one of the changesets showing some relations in the "Deleted" category even though the relations were modified and not deleted.