Improve Cypress script
UlisesGascon opened this issue · 5 comments
Context
- This is part of
release-1.5#148 - Critical task
Tasks
- Improve the speed of the e2e tests (almost 8 minutes now). Maybe videos are generated (ci/local envs)
- Add test that are missing (fast check)
- Remove unnecessary/repetitive tests
- Improve the command
dbReset. Missing validation due Travis conflicts - Check that the npm tasks are working as expected
- Update the
readme.mdwith the extra relevant info (if needed)
Assignation
- This tasks is open for assignation, just claim it (as reply to this) and submit your PR ;-)
Important
- Check the current roadmap #148
- Don't forget to check the Contributing Guidelines and follow the Code of Conduct
I'd like to help with this. I've been looking at some performance improvements to the tests and also making them more reliable.
To start, I'd like to make pull requests for two fixes that should resolve the signup test flakiness:
- Make db-reset.js wait for
dropCollectionsto complete before inserting new data - Set necessary env vars in
docker-compose.ymlto make the web service use the mongo service (instead of mongolab)
The first one affects branches master and feature/187. The second currently only affects feature/187, because master isn't using docker in Travis.
I have more to follow, but these are higher priority because they make the tests reliable. Making these changes should save a lot of time looking into false build failures.
@UlisesGascon, which branch(es) would you prefer the pull request(s) to be made against?
To start, I'd like to make pull requests for two fixes that should resolve the signup test flakiness:
Both these fixes were merged into master in c44bbd6.
The fix to set MONGODB_URI in docker builds needs to be merged into feature/187 before January 12, 2021. On that date the mLab database currently used by CI in this branch will be shut down, causing all subsequent Travis jobs to fail.