livereload.js making tests run slower
rcowsill opened this issue · 2 comments
The view templates all reference the livereload.js script, but that file is only available when the livereload service is running (grunt watch). If the livereload service isn't up, then the livereload.js request has to time out before page load is completed. I see the browser's loading spinner continue for a few seconds after each page is displayed.
When running tests it seems that cypress waits for page loads to finish before proceeding. I tested locally with the livereload script removed from the templates and it makes the tests significantly faster. A full cypress run went from ~20 minutes (!) to 1m20. I'm not sure how representative that is; on Travis it currently takes ~4 mins.
The grunt watch docs suggest conditionally enabling the livereload script in templates based on a dev flag. I have a rough version of that working now if you'd be interested in trying it out.
I tried the WIP changes in my fork using Travis:
| Build | Node 8 | Node 10 | Node 12 |
|---|---|---|---|
| Before | 7m00s | 7m21s | 7m34s |
| After | 4m24s | 4m39s | 4m39s |
The before timings look comparable to the last master branch build.
EDIT: Found an alternative fix, we could tell cypress to ignore resources from localhost:35729. That should speed up the CI and would only be a few extra lines of config.
For future reference, #216 fixes this for production and test environment. ec40213 is also needed to cover development environment (eg contributors running tests locally during dev)
I mention it because Cypress changed the name of the setting to blockHosts in 5.0, so we'll need to update the config when upgrading. See https://docs.cypress.io/guides/references/migration-guide.html#Migrating-to-Cypress-5-0