Task that exit with error should set the exit code

Question

Task that exit with error should set the exit code

omerlh opened this issue 7 years ago · 2 comments

Task should be able to report a fatal error by setting the exit code. Currently I tried Glue.error, but it only reports the error and not setting the exit code to 1. I think that if task encounter fatal error, it should be detectable by the CI tool and the build should fail.

Answer 1 · 2017-07-04T02:49:28.000Z

Interesting. So far we assume we will signal with the -z flag to send a signal if there are issues but I agree, if there is an error it should also fail.

Maybe we should add a fatal error level that exits immediately and sets that code. Would that fit what you are thinking?

Answer 2 · 2017-07-04T06:45:39.000Z

Yeah, that sounds good to me. I could add a PR for that in the next few days hopefully...