API documentation has incorrect usage for forHtmlAttribute
thariyarox opened this issue · 2 comments
thariyarox commented
n the API documentation, forHtmlAttribute method's example usage is listed as following.
<%=Encode.forHtml(unsafeData)%>
It should be corrected as following.
<%=Encode.forHtmlAttribute(unsafeData)%>
I have corrected it and sent the PR [2]. Please review and merge.
[1] https://owasp.github.io/owasp-java-encoder/encoder/apidocs/org/owasp/encoder/Encode.html#forHtmlAttribute-java.lang.String-
[2] #23
jmanico commented
Excellent. We’re planning a “we are still here” point release soon which will include this fix. Thanks for the patch! Love it!
Aloha,
Jim
… On Aug 19, 2018, at 12:04 AM, Tharindu Edirisinghe ***@***.***> wrote:
n the API documentation, forHtmlAttribute method's example usage is listed as following.
<%=Encode.forHtml(unsafeData)%>
It should be corrected as following.
<%=Encode.forHtmlAttribute(unsafeData)%>
I have corrected it and sent the PR [2]. Please review and merge.
[1] https://owasp.github.io/owasp-java-encoder/encoder/apidocs/org/owasp/encoder/Encode.html#forHtmlAttribute-java.lang.String-
[2] #23
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
jmanico commented
Released and is live with version 1.2.2!