OWASP/owasp-java-encoder

Compile error

SOLcoelle opened this issue · 6 comments

SOLcoelle commented

Compilation breaks with org.owasp.esapi:esapi:2.5.1.0 because org.owasp.encoder.esapi.ESAPIEncoder.Impl does not implement the new methods

  • org.owasp.encoder.esapi.ESAPIEncoder.Impl#decodeFromJSON
  • org.owasp.encoder.esapi.ESAPIEncoder.Impl#encodeForJSON

which were introduced with the 2.5.1.0.

Solution (?):

  • Set a fix dependency on the previous version of org.owasp.esapi:esapi
  • Implement and test the missing interface functions
  • Update the dependency
kwwall commented
TheMarvelFan commented

Hi,
What is the latest on this issue?

kwwall commented

@TheMarvelFan - I never heard back from @manicode (but perhaps that's because he's not using GH handle @jmanico) so I never submitted a PR. But given that I and on the verge of releasing a new ESAPI release (2.5.3.0) in the next day or two, it seems prudent to wait until that is released.

@jmanico - I think this is related to the esapi-thunk portion of the OWASP Java Encoder project. I think the fix should be pretty easy.

TheMarvelFan commented

Alright I will check back after 2 days, and open a PR asap.

jmanico commented

Kevin, I have not touched this in a while. Would you care to help?

kwwall commented