unsubscribe issues python 3?
jneilliii opened this issue · 4 comments
jneilliii commented
What were you doing?
Discussion on the issue in forum here
Seems that unsubscribe may have an issue in Python 3
Quoting @cp2004...
In Python 3, filter() returns an iterable object whereas in Python 2 it returned a list. Likely where the error comes from.
What did you expect to happen?
no errors when unsubscribing
What happened instead?
errors were thrown
Version of OctoPrint
unsure, assuming 1.6.0.
Version of the MQTT plugin
0.8.9
Used MQTT broker and its version
Link to octoprint.log
will work on reproducing issue and provide logs
Link to contents of Javascript console in the browser
n/a
Screenshot(s)/video(s) showing the problem
n/a
GitIssueBot commented
This issue has been mentioned on OctoPrint Community Forum. There might be relevant details there:
https://community.octoprint.org/t/new-plugin-mqtt-for-psucontrol/33886/10
jneilliii commented
Awaiting confirmation above commit resolves the issue. If it does I will bump version, merge, and release.
oerkel47 commented
This did indeed fix it for my plugin. Do you still have a need for logs?