`wait_for_deployment` setting to true does not make the action wait

[aziz-shahed-cko]

Hi,
Im using OctopusDeploy/create-release-action with the following set up

    - name: Create and deploy release
      uses: OctopusDeploy/create-release-action@v1.1.3
      with:
        api_key: ${{ inputs.OctopusApiKey }}
        server: ${{ inputs.OctopusServerUrl }}
        space: "Default"
        project: ${{ inputs.OctopusProjectName }}
        channel: ${{ inputs.OctopusChannelName }}
        release_number: ${{ inputs.Version }}
        progress: true
        wait_for_deployment: true
        deployment_timeout: ${{ inputs.OctopusDeploymentTimeout }}

I was expecting the action to wait and get feedback from octopus to indicate if the deployment was successful or not. But it does not wait and just says the release is created while on octopus server the release is in progress

🐙 Creating a release in Octopus Deploy...
🎉 Release 1.1.0 created successfully!

Expected behavior:
Action should wait for response from octopus server

[hnrkndrssn]

Hey @aziz-shahed-cko thanks for getting in touch.

With the configuration you've provided you're not actually deploying the release to an environment after creating the release, you have to include the deploy_to parameter for it to deploy the release and then the wait_for_deployment argument will kick in and show the progress of the release.

Hope that helps.

Cheers.

[aziz-shahed-cko]

Hi @hnrkndrssn , thank you for the explanation, I now understand the dependency between wait_for_deployment and deploy_to.
The issue is, on octopus, we deploy to channels which you can see from the line channel: ${{ inputs.OctopusChannelName }}.

Each channel contains lifecycle and the life cycle decides which environment to deploy to. As for example, lets say the channel name Default has Development lifecyle which got 2 phases. First phase deploys to dev environment and second phase deploys to qa environment.

So with set up like ours, is it that case that Octopus action will never be able to wait till the deployment to the environment is done via phase of lifecyle in the channel?

[hnrkndrssn]

Hi @aziz-shahed-cko,

That is correct that if you're auto-deploying releases via lifecycles you cannot wait until the deployment has finished.

Cheers.

[aziz-shahed-cko]

Thank you so much for the clarification @hnrkndrssn. Im closing the issue