network.py - Naming convention
yeroc-sebrof opened this issue · 3 comments
yeroc-sebrof commented
In the code you need a bit more consistency in future.
E.g.
Line 40 - def network_on(self)
Line 47 - def network_down(self):
(On, Off) or (Up,Down)
yeroc-sebrof commented
Also it should be g_ether over gether
OffBy0x01 commented
@yeroc-sebrof or even just
ether_up
ether_down
since we don't really care that it is using USB gadgets (we already know this)
yeroc-sebrof commented
Finally, network_remove
could be replaced with the default system call for deleting the class objects.
An example of this being
def __del__(self):
Followed by the contents.