OffBy0x01/usbskeletonkey

network.py - Naming convention

yeroc-sebrof opened this issue · 3 comments

In the code you need a bit more consistency in future.
E.g.
Line 40 - def network_on(self)
Line 47 - def network_down(self):

(On, Off) or (Up,Down)

Also it should be g_ether over gether

@yeroc-sebrof or even just

ether_up
ether_down

since we don't really care that it is using USB gadgets (we already know this)

Finally, network_remove could be replaced with the default system call for deleting the class objects.

An example of this being
def __del__(self): Followed by the contents.