Invalid and missing compound types
benerobert opened this issue · 4 comments
Hi!
The compoundTypes in BaseType.cs do not fully correspond to the table in MS-FSSHTTPB in section 2.2.1.5.2. The value of 'Response (FsshttpbResponse)' is missing and 'Target Partition Id' should be a non-compound type according to the table.
Therefore, a header is added at the end of TargetPartitionId, but it is not required by the protocol specification, since it is not a compound type.
Have a nice day!
@benerobert
After I did investigation, the reason why Target Partition Id End is added in Test Suite code is that Target Partition Id End exists in ms-fsshttpb v20140430, but was removed then. I am trying to remove this field from Test Suite code to see if test case is still working.
For response field, I think it would be good to add. Now it is not invoked in test suite code, so has not added it.
@benerobert After verification, test suite code works well after removing Target Partition Id End to change Target Partition Id as a single object. The server could response no matter Target Partition Id is a single or compound object in the request. And response is also added. The changes have been merged into my master branch https://github.com/ChangDu2021/Interop-TestSuites, could you please help check if it is working at your side? If yes, I will merge it into prod master branch.
Below is the pull request to have the changes:
ChangDu2021#50
@ChangDu2021 With this change, tests now run successfully on my site.
@benerobert Sounds good. Could you please close this issue if you don't have any other questions?