Makefile calls 'git submodule' even when there's no '.git' directory
Closed this issue · 3 comments
Hello! I've run into one more problem on Heroku.
Before Heroku builds a project, it checks out the source tree with git submodule update --init --recursive, and then deletes all the .git directories. This means that the rules in your make deps target fail when I try to build on Heroku.
Do you think that you could somehow modify this rule so that it will work right if rust-http is already there, but all the .git directories are gone?
Thank you very much for answering my questions, and for such a helpful library!
I see. I think the easiest solution would be to just check if the main .git directory exists (since it wouldn't be a complete git repository without it anyway) and only run the git commands if it does. I don't think that would interfere with anything else. Hold on.
Ok, give it a try and see if it works as expected. Otherwise, you can always post a pull request with a working solution.
This works wonderfully! Thank you very much for your two rapid improvements to get stuff working on Heroku.