audioelement is not defined

Question

audioelement is not defined

surmon-china opened this issue 8 years ago · 5 comments

Hello, thank you for this powerful project!

I used the process found that when I use the connectExternalAudioElement method, it will prompt audioelement is not defined, seemingly because the compressed package variable name is not caused.

Answer 1 · 2017-03-26T15:55:24.000Z

Hey, thanks for your feedback.

This look like a stupid mistake from me (I should add some UnitTest to prevent this) i just wrote audioelement instead of audioElement

I will hotfix this right now.

Answer 2 · 2017-03-26T16:02:14.000Z

I fixed this in v2.0.2, just update your dependency and it should work :) !

Answer 3 · 2017-03-26T16:05:38.000Z

Oh, I missed a little ...

the _this.audioElement should be _this.audio

https://github.com/Okazari/Rythm.js/blob/master/rythm.js#L102

https://github.com/Okazari/Rythm.js/blob/master/rythm.js#L104

Answer 4 · 2017-03-26T16:06:51.000Z

You're right ! Wait a sec ;)

Answer 5 · 2017-03-26T16:11:01.000Z

v2.0.3 should be the one !