Okazari/Rythm.js

Expose a connectExternalStream() function

Okazari opened this issue · 3 comments

Okazari commented

Rythm.js/src/Player.js

Line 60 in e1c7d75

return this.getMicrophoneStream().then(stream => {

Externalise this arrow function into a connectStreamSource(), expose it in the api and add it to the documentation

nesvand commented

Here I was hoping for an evening of helping to close up this ticket for you and you already seem to have it implemented. It looks like your work from 33274ee and onwards has resolved this ticket - let's close it up! ;)

Okazari commented

In my opinion connectSource is a bit too "low level". It's intented to connect an already created AudioSource to rythm.

What i would love to give as API is more like connectExternalStream (I think the issue name have a mistake, i will update it) which is nothing more than the function given to .then() in the linked line.

WDYT ?

nesvand commented

Sure let me think on it - I'll re-familiarise myself with the project (as it has been updated a bit since I last checked!) ;)