Use generate instead of setgenerate

Question

dexX7 opened this issue 8 years ago · 4 comments

The 0.13 based Omni Core currently forwards requests for setgenerate, but ultimately OmniJ should use the new RPC generate, to generate a block.

Answer 1 · 2016-12-09T19:32:48.000Z

I thought I had already done this -- maybe I missed some cases? I'll double-check -- and I agree.

Answer 2 · 2016-12-09T19:34:32.000Z

Wait, maybe I missed the update. I haven't actually tested it without the forward.

Answer 3 · 2016-12-09T20:22:12.000Z

There is still some cleanup around generate / setgenerate but I'm pretty sure setgenerate is no longer being used in any of the RegTests.

I just now made some further (final?) changes in this area:

Answer 4 · 2016-12-10T10:54:26.000Z

Looks good to me! Even without the forward (OmniLayer/omnicore#440) the OmniJ tests pass.