Test schema of Omni Core API
Opened this issue · 2 comments
Most tests we currently have focus on correct behavior and logic, but only a fraction of the information of the API is actually used.
I'm not sure, how to tackle this, but it would be great, if all fields of the results for each command are checked somewhere, similar to the ListPropertiesSpec.
I started to tackle this in light of OmniLayer/omnicore#173 and OmniLayer/omnicore#174, however, I'd appreciate, if you could give me a design advice:
Currently I test all different types of transactions via "omni_gettransaction" in one specification, but it is also thinkable, maybe even better practise, to split and move those checks in the sub packages (e.g. foundation.omni.test.rpc.mdex, ...).
So I'm basically wondering: where should I put the tests? If you think it's better to split them and add them to the packages, then it raises the question, whether they should be part of the main specification (e.g. MetaDexSpec, ...), or rather placed into a new specification, but for each package, say for example something like foundation.omni.test.rpc.mdex.GetTransactionSpec?
This is how it currently looks like:
Other comments are of course welcomed!
Sorry @dexX7 , I'll take a look at this soon.