OnTopicCMS/OnTopic-Editor-AspNetCore

Bug: Not all topics displayed in `TokenizedTopicList` lookup

Closed this issue · 2 comments

As an example, searching for Country in a RootTopic look (e.g., for a TopicList) should bring up:

Root:Configuration:Metadata:Country

Currently, it doesn't. In this scenario, existing values may also not be being displayed correctly. For example, see:

Root:Configuration:Attributes:FormData:Country

This appears to derive from a bug in the underlying query service. This can be demonstrated using the following link:

/OnTopic/Json/Root?FlattenStructure=true&Query=Country

This appears to be due to the fact that Country, specifically, doesn't have a Title and, thus, no matches can be found in the Topic.Attributes collection. This is an inadvertent effect of moving the Key out of Topic.Attributes, as the TopicQueryService doesn't explicitly check Topic.Key. This should be an easy fix.

This was resolved by including an explicit check of Topic.Key in the TopicQueryService's IsValidTopic() method (381b754).