OneSignal/react-native-onesignal

[Bug]: Setting `OneSignal.Notifications.requestPermission` parameter `fallbackToSettings` to `false` has no effect

hrastnik opened this issue · 4 comments

hrastnik commented

What happened?

When calling OneSignal.Notifications.requestPermission it's possible to pass a parameter fallbackToSettings which should control whether the in-app Open Settings prompt will display when the native prompt has been rejected. However, this parameter has no effect and the Open Settings prompt shows always

Steps to reproduce?

1. Call `await OneSignal.Notifications.requestPermission(false);`
2. The "Open Settings" prompt will show

What did you expect to happen?

The prompt should not show up.

React Native OneSignal SDK version

5.2.2

Which platform(s) are affected?

  • iOS
  • Android

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
martin-key commented

Same here. This issue should be marked as Major as we have received multiple reports by uses.

  • 👍1
aharonphytech commented

I opened PR addressing this issue:
#1729

aharonphytech commented

@jennantilla, thank you for merging the PR. I believe the issue should be resolved now

jennantilla commented

Thanks for your patience, everyone! Release 5.2.3 is ready. I'll go ahead and close this out but please let us know if there are any additional questions or concerns.