OnionUI/Onion

Activity Tracker : update boxart after the game has been added to the database

Opened this issue · 11 comments

schmurtzm commented

Currently adding a box art (with Scraper or else) doesn't actualize the game cover in Activity Tracker.

This is due to the fact that Activity Tracker stores the image path in a db instead of generating the image path dynamically.

Aemiii91 commented

I think we should just get the box art image dynamically (by checking if the png exist) - instead of having to keep a db up-to-date

  • 👍1
theUnBurn commented

@schmurtzm I made a fix for this issue here: #1305

Would love feedback! Particularly around on if we should update the db to no longer have an image path (and, if so, how to do that).

  • 👍3
  • 🚀1
Prozi commented

@schmurtzm I made a fix for this issue here: #1305

Would love feedback! Particularly around on if we should update the db to no longer have an image path (and, if so, how to do that).

I love the mr #1305 please merge it to next onion dev release please

Prozi commented

@Aemiii91 how can I support MR #1305

Prozi commented

Would love feedback! Particularly around on if we should update the db to no longer have an image path (and, if so, how to do that).

I wouldn't remove the field in db or update it, this way:

if someone installs newer onionos, has some activities in db, then decides to downgrade, his db will still work with older onion (backwards compatibility)

schmurtzm commented

Hi, I have a problem with this PR... Curiously I'm not able to triggers the initial problem . Hum...😅
Quickly tested the actual Activity Tracker and I don't see any problem : changing the cover of a game impacts Activity Tracker too. I don't remember in which case the fact that Activity Tracker keeps the path of the image is a problem anymore. 😶

Prozi commented

Hi, I have a problem with this PR... Curiously I'm not able to triggers the initial problem . Hum...😅 Quickly tested the actual Activity Tracker and I don't see any problem : changing the cover of a game impacts Activity Tracker too. I don't remember in which case the fact that Activity Tracker keeps the path of the image is a problem anymore. 😶

in that case @schmurtzm at least please reopen #1419 because that was a bit different (missing images on games, dont update, dont show, nothing, in activity tracker, but they are scraped prior, more details in linked issue)

Prozi commented

the first example I recall is Tony Hawk's Pro Skater 4 on PS

Prozi commented

@Aemiii91 any progress on this one if this is a duplicate of 1441 as you said there?

Prozi commented

@schmurtzm did you try this on any PSX games like I said in my issue? did you try this with THPS4?

also, see:

20240225_213134.2.mp4
XK9274 commented

Thanks for the feedback, Lets keep it constructive.

  • 😕1