Sometimes Hints can hint locations inside pre-Completed Dungeons

https://ootrandomizer.com/seed/get?id=1478403

Spirit in that seed is pre-Completed. (empty)

The Gossip Stones on the other Hand gives us following info: "They say that upon the Colossus's right hand is a Small Key."

It seems that line 152 in Fill.py is not doing the job anymore. (Or it never did what I thought it does and I just got extra-lucky on all my tests?)

OoT-Randomizer/Fill.py

Lines 147 to 153 in 35eb6fc

    
           if worlds[0].settings.empty_dungeons_mode != 'none': 
        
               empty_locations = [location for location in fill_locations 
        
                                  if location.world.empty_dungeons[HintArea.at(location).dungeon_name].empty] 
        
               for location in empty_locations: 
        
                   fill_locations.remove(location) 
        
                   location.world.hint_type_overrides['sometimes'].append(location.name) 
        
                   location.world.hint_type_overrides['random'].append(location.name)

I'm afraid I'm not familiar with the hint system and I don't have much free time these days, so I'm just leaving this piece of code here as a starter in case someone wants to tackle the problem.

	if worlds[0].settings.empty_dungeons_mode != 'none':
	empty_locations = [location for location in fill_locations
	if location.world.empty_dungeons[HintArea.at(location).dungeon_name].empty]
	for location in empty_locations:
	fill_locations.remove(location)
	location.world.hint_type_overrides['sometimes'].append(location.name)
	location.world.hint_type_overrides['random'].append(location.name)