OpenAdaptAI/OpenAdapt

Mac trackpad gestures are unsupported

dianzrong opened this issue · 3 comments

dianzrong commented

I'm not sure if there are similar issues with other trackpads but currently some macbook trackpad gestures aren't logged or logged incorrectly.

abrichr commented

Thanks for flagging @dianzrong ! We use https://github.com/moses-palmer/pynput to record and replay actions. Here are a couple of issues that seem relevant:

moses-palmer/pynput#513

moses-palmer/pynput#327

Either we should implement a fix in https://github.com/abrichr/pynput, or at the very least we should update our README to indicate that these are unsupported.

dianzrong commented

After looking into this issue, I think our time would be best used elsewhere, so our README should be updated. I also discovered that touchpad gestures (with Windows 10) are also not supported

  • 👍1
dianzrong commented

Note:

  • we would probably want a touchpad folder in pynput/lib where we could put the code for the different operating systems
    • if we wanted to windows touchpad gestures (list)to be logged, we can use their GetTouchProperties class to detect if there's a touchpad
    • On Apple we would do something similar to what’s done in pynput/lib/mouse/_darwin with NSEvent but with the touch-based events here
  • 👍1